services/horizon/ingest: historyRange and reingestHistoryRange states send batches of ledgers to tx processors #5117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… send batches of ledgers to processors
sreuland
commented
Nov 17, 2023
sreuland
commented
Nov 17, 2023
urvisavla
reviewed
Nov 20, 2023
urvisavla
reviewed
Nov 20, 2023
tamirms
reviewed
Nov 21, 2023
tamirms
reviewed
Nov 21, 2023
tamirms
reviewed
Nov 27, 2023
…st max flush size if lower than default of 100
tamirms
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Changed the
historyRangeandreingestHistoryRangestate machines to send batches of ledgers to tx processors to be processed into memory and then flushed to current db tx once.For context, the pre-req of tx processors enablement with fast batch builders for holding multiple ledger updates in memory and then flushing once was merged in #4909, this changeset builds upon that by now letting these ranged state machine ingestions to pass a range of ledgers to the tx processors.
The batch size of ledgers is configurable per
Config.MaxLedgerPerFlushWhy
Ingestion performance, reducing the number of db round trips for tx commits to lower overall time to finish ingestion range.
Closes #5099
Known limitations
this batching of ledgers for db round trips was only applicable to the two reingest states
historyRangeandreingestHistoryRange